Re: fix for readline terminal size problems when window is resized with open pager - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: fix for readline terminal size problems when window is resized with open pager
Date
Msg-id 20151214200019.GD2618@alvherre.pgsql
Whole thread Raw
In response to Re: fix for readline terminal size problems when window is resized with open pager  (Merlin Moncure <mmoncure@gmail.com>)
List pgsql-hackers
Merlin Moncure wrote:
> On Tue, Dec 8, 2015 at 2:33 PM, Merlin Moncure <mmoncure@gmail.com> wrote:
> > On Tue, Dec 8, 2015 at 2:02 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> I wrote:
> >>> Merlin Moncure <mmoncure@gmail.com> writes:
> >>>> The following patch deals with a long standing gripe of mine that the
> >>>> terminal frequently gets garbled so that when typing.
> >>
> >>> Hm.  I wonder whether rl_resize_terminal() exists in every iteration
> >>> of libreadline and libedit.
> >>
> >> Quick followup: rl_resize_terminal() exists in GNU readline at least as
> >> far back as 4.0 (released Feb 1999).  However, it doesn't seem to be there
> >> at all in libedit; I don't see it in OS X Yosemite's headers, anyway.
> >> So we'd need a configure test for this.
> >
> > All right, I guess this answers the question I was thinking, 'can this
> > be backpatched?' (basically, now).
> 
> er, meant to say, 'no'.

Why not?  We don't forbid adding configure tests in minor releases, do
we?

I've been troubled by this many times, so thanks for finding the problem
and fixing.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Uninterruptible slow geo_ops.c
Next
From: Tomas Vondra
Date:
Subject: PATCH: postpone building buckets to the end of Hash (in HashJoin)