Postgres Pro
Downloads
Home   >   mailing lists

Re: GIN pending list clean up exposure to SQL - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: GIN pending list clean up exposure to SQL
Date
Msg-id 20151119155222.GJ614468@alvherre.pgsql
Whole thread Raw
In response to GIN pending list clean up exposure to SQL  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: GIN pending list clean up exposure to SQL  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Jeff Janes wrote:
> I've written a function which allows users to clean up the pending list.
> It takes the index name and returns the number of pending list pages
> deleted.

I just noticed that your patch uses AccessShareLock on the index.  Is
that okay?  I would have assumed that you'd need ShareUpdateExclusive
(same as vacuum uses), but I don't really know.  Was that a carefully
thought-out choice?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change
Next
From: Tom Lane
Date:
Subject: Re: [PROPOSAL] TAP test example