Re: warning: HS_KEY redefined (9.5 beta2) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: warning: HS_KEY redefined (9.5 beta2)
Date
Msg-id 20151119131122.GI614468@alvherre.pgsql
Whole thread Raw
In response to Re: warning: HS_KEY redefined (9.5 beta2)  (Erik Rijkers <er@xs4all.nl>)
Responses Re: warning: HS_KEY redefined (9.5 beta2)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Erik Rijkers wrote:

> In file included from ../../../src/include/postgres.h:48:0,
>                  from plperl.c:8:
> plperl.c: In function ‘select_perl_context’:
> ../../../src/include/utils/elog.h:41:16: warning: passing argument 1 of
> ‘errmsg’ makes pointer from integer without a cast [-Wint-conversion]

Uh, this code has evidently never been compiled before, because it's
completely bogus:

#else    errmsg(ERROR,           (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),            errmsg("cannot allocate multiple
Perlinterpreters on this platform")));
 
#endif

It's recent breakage though, introduced in 09cecdf285ea.  Need to
s/errmsg/ereport/ ..

> make contrib:
> In file included from hstore_plperl.c:6:0:
> ../../contrib/hstore/hstore.h:79:0: warning: "HS_KEY" redefined
>  #define HS_KEY(arr_,str_,i_) ((str_) + HSE_OFF((arr_)[2*(i_)]))
>  ^
> In file included from
> /opt/perl-5.22/lib/5.22.0/x86_64-linux/CORE/perl.h:3730:0,
>                  from ../../src/pl/plperl/plperl.h:48,
>                  from hstore_plperl.c:4:
> /opt/perl-5.22/lib/5.22.0/x86_64-linux/CORE/util.h:226:0: note: this is the
> location of the previous definition
>  #  define HS_KEY(setxsubfn, popmark, apiver, xsver) \
>  ^

So we need to get this one fixed.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Marko Tiikkaja
Date:
Subject: Re: COPY (INSERT/UPDATE/DELETE .. RETURNING ..)
Next
From: David Steele
Date:
Subject: Re: Additional role attributes && superuser review