Re: [COMMITTERS] pgsql: Cleanup commit timestamp module activaction, again - Mailing list pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Tom Lane wrote:
> >> I think it's just failure to update an expected-file, but will leave it
> >> to Alvaro.
> 
> > I don't understand.  It passed make check fine for me on both branches.
> > Will fix in a jiffy.
> 
> There are two variant expected files for that module --- did you fix
> both?

Yeah, this was the problem: make installcheck almost always exercises
the case with the setting disabled, which make check doesn't test.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services