Re: PATCH: 9.5 replication origins fix for logical decoding - Mailing list pgsql-hackers

From Andres Freund
Subject Re: PATCH: 9.5 replication origins fix for logical decoding
Date
Msg-id 20151015125536.GE6851@awork2.anarazel.de
Whole thread Raw
In response to Re: PATCH: 9.5 replication origins fix for logical decoding  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: PATCH: 9.5 replication origins fix for logical decoding  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On 2015-10-15 20:52:41 +0800, Craig Ringer wrote:
> You'll note that the tests fail. When the replication origin is reset
> and set again with pg_replication_origin_xact_setup mid-xact, the
> origin identity exposed to the decoding plugin callbacks for all
> records (including those created before the origin change) is the
> latter origin, the one active at COMMIT time.
> 
> Is that the intended behaviour? That the session identifier is
> determined by what was active at commit time, and only the lsn and
> timestamp vary throughout the xact? It looks like it from the code.

Uh. Isn't that just because you looked at txn->origin_id instead of the
change's origin_id?


Andres



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: PATCH: 9.5 replication origins fix for logical decoding
Next
From: Robert Haas
Date:
Subject: Re: Parallel Seq Scan