Re: factor out encoding dependent json/jsonb regression tests - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: factor out encoding dependent json/jsonb regression tests
Date
Msg-id 20151005181444.GG8531@alvherre.pgsql
Whole thread Raw
In response to factor out encoding dependent json/jsonb regression tests  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> I'm rather tired of having to update two sets of output files every time we
> change the json and jsonb regression tests. Also, other committers
> occasionally fall over this trap and fail to update json_1.out and
> jsonb_1.out, as do almost all other patch authors. I propose that we remove
> those tests to quite small json_utf8.sql and jsonb_utf8.sql (which will each
> have 2 output files) and that will allow us to get rid of json_1.out and
> jsonb_1.out. I'd like to backpatch this to 9.4 for jsonb and 9.2 for json.

+1.

> Alternatively, for >= 9.4 we could just add the jsonb encoding-specific
> tests to json_utf8.sql, to avoid a greater proliferation of tests.

shrug

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Oleksii Kliukin
Date:
Subject: Re: run pg_rewind on an uncleanly shut down cluster.
Next
From: Stas Kelvich
Date:
Subject: Tsvector editing functions