Re: perlcritic - Mailing list pgsql-hackers

From Andres Freund
Subject Re: perlcritic
Date
Msg-id 20151003135330.GF3323@alap3.anarazel.de
Whole thread Raw
In response to perlcritic  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Hi,

On 2015-08-31 23:57:25 -0400, Peter Eisentraut wrote:
> We now have 80+ Perl files in our tree, and it's growing.  Some of those
> files were originally written for Perl 4, and the coding styles and
> quality are quite, uh, divergent.  So I figured it's time to clean up
> that code a bit.  I ran perlcritic over the tree and cleaned up all the
> warnings at level 5 (the default, least severe).

As far as I can see we haven't really come to any conclusion in this
thread?

Peter, where do you want to go from here? As this patch has been in
waiting-for-author for a month, I'm marking it as
returned-with-feedback.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.
Next
From: Andres Freund
Date:
Subject: Re: Unicode mapping scripts cleanup