Re: 9.5: Can't connect with PGSSLMODE=require on Windows - Mailing list pgsql-hackers

On 2015-09-28 17:28:48 -0400, Tom Lane wrote:

> > What I do find curious is that afaics before 680513ab79 the code also
> > looked at errno, not SOCK_ERRNO. And apparently things worked back then?
> 
> No; AFAICS, before that commit, libpq did not use a custom BIO at all.
> That commit cloned the backend's custom BIO, but did not correctly
> adjust the backend's errno handling for the libpq environment.

Oh, yea.

> Will go fix it.

We now probably could remove* XXX OpenSSL 1.0.1e considers many more errcodes than just EINTR as reasons* to retry; do
weneed to adopt their logic for that?
 
since we now actually check for more tahn just EINTR.

Greetings,

Andres Freund