Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

On 2015-08-11 12:43:03 -0400, Robert Haas wrote:
> On Tue, Aug 11, 2015 at 12:40 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > We do not use !! elsewhere for this purpose, and I for one find it a
> > pretty ugly locution.
> 
> We do, actually, now, in contrib/pg_xlogdump/pg_xlogdump.c.  I'd be in
> favor of getting rid of those.

And a bunch more places actually. Blame me. I'll come up with a patch
fixing the macros and converting existing !! style ones.

- Andres