Re: pgsql: Add some test coverage of EvalPlanQual with non-locked tables. - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Add some test coverage of EvalPlanQual with non-locked tables.
Date
Msg-id 20150729173916.GJ2441@postgresql.org
Whole thread Raw
In response to pgsql: Add some test coverage of EvalPlanQual with non-locked tables.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> Add some test coverage of EvalPlanQual with non-locked tables.
>
> A Salesforce colleague of mine griped that the regression tests don't
> exercise EvalPlanQualFetchRowMarks() and allied routines.  Which is
> a fair complaint.  Add test cases that go through the REFERENCE and COPY
> code paths.  Unfortunately we don't have sufficient infrastructure right
> now to exercise the FDW code path in the isolation tests, but this is
> surely better than before.

FWIW the test_decoding module has isolation tests (pretty ugly
admittedly).  I guess you could do something similar in the postgres_fdw
module.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make TAP tests work on Windows.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix TAP tests with "make installcheck".