Re: [PATCH] postgres_fdw extension support - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] postgres_fdw extension support
Date
Msg-id 20150721182704.GF13636@awork2.anarazel.de
Whole thread Raw
In response to Re: [PATCH] postgres_fdw extension support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] postgres_fdw extension support  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2015-07-21 14:07:24 -0400, Tom Lane wrote:
> Paul Ramsey <pramsey@cleverelephant.ca> writes:
> > Folks are going to be OK w/ me dropping in new syscache entries so support my niche little feature?
> 
> No, mainly because it adds overhead without fixing your problem.

Meh. pg_extension updates are exceedingly rare, and there's a bunch of
code in extension.c that could very well have used a syscache instead of
doing manual scans over the table.

> It's not correct to suppose that a syscache on pg_extension would
> reliably report anything; consider ALTER EXTENSION ADD/DROP, which
> does not touch the pg_extension row.

I'd have just brute-force solved that by forcing a cache inval in that
case.


But I'm not going to complain too loudly if we don't do invalidation.

Andres



pgsql-hackers by date:

Previous
From: "Todd A. Cook"
Date:
Subject: Re: WAL logging problem in 9.4.3?
Next
From: Paul Ramsey
Date:
Subject: Re: [PATCH] postgres_fdw extension support