Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)
Date
Msg-id 20150612070525.GA12515@toroid.org
Whole thread Raw
In response to Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
At 2015-06-11 14:38:03 +0900, Langote_Amit_f8@lab.ntt.co.jp wrote:
>
> > On the other hand, I don't like the idea of doing (3) by adding
> > command line arguments to pg_basebackup and adding a new option to
> > the command. I don't think that level of "flexibility" is justified;
> > it would also make it easier to end up with a broken base backup (by
> > inadvertently excluding more than you meant to).
> 
> Maybe a combination of (2) and part of (3). In absence of any command
> line argument, the behavior is (2), to exclude. Provide an option to
> *include* it (-S/--serverlog).

I don't like that idea any more than having the command-line argument to
exclude pg_log. (And people who store torrented files in PGDATA may like
it even less.)

-- Abhijit



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pg_rewind failure by file deletion in source server
Next
From: Michael Paquier
Date:
Subject: Re: pg_rewind failure by file deletion in source server