Re: Need Force flag for pg_drop_replication_slot() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Need Force flag for pg_drop_replication_slot()
Date
Msg-id 20150529173957.GA24118@alap3.anarazel.de
Whole thread Raw
In response to Need Force flag for pg_drop_replication_slot()  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Need Force flag for pg_drop_replication_slot()  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Hi,

On 2015-05-29 10:15:56 -0700, Josh Berkus wrote:
> pg_drop_replication_slot() can be a time-critical function when the
> master is running out of disk space because the replica is falling
> behind.

I don't buy this argument. The same is true for DROP TABLE, TRUNCATE,
DROP DATABASE etc.

I mean, I agree it'd be convenient, but I can't see it as "critical".

> While I'm just doing this during testing, it could be a critical fail in
> production.  I think the simplest way to resolve this would be to add a
> boolean flag to pg_drop_replication_slot(), which would terminate the
> replication connection and delete the slot as a single operation.

There's no "single operation" for terminating a backend *and* doing
something...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgindent vs emacs
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: fsync-pgdata-on-recovery tries to write to more files than previously