Re: Run pgindent now? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Run pgindent now?
Date
Msg-id 20150522145234.GW5885@postgresql.org
Whole thread Raw
In response to Re: Run pgindent now?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Run pgindent now?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Robert Haas wrote:
> On Tue, May 19, 2015 at 10:26 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > To do it before every minor release would require re-indenting HEAD
> > as well (since the whole point is to keep HEAD and the back branches
> > consistent).  I think we'd get too much push-back from developers
> > whose pending patches got broken.  We can get away with reindenting
> > HEAD between development cycles, but probably not more often than that.
> 
> I'm not convinced of that.  If we did it more often, it might actually
> be less disruptive.

I believe it's possible to mechanically rebase a patch over an indent
run of the underlying branch with half a dozen commands or less.  +1 for
reindenting all branches before each minor release, FWIW.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Missing importing option of postgres_fdw
Next
From: Tom Lane
Date:
Subject: Re: Run pgindent now?