Re: Final Patch for GROUPING SETS - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Final Patch for GROUPING SETS
Date
Msg-id 20150514171811.GI9584@alap3.anarazel.de
Whole thread Raw
In response to Re: Final Patch for GROUPING SETS  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
On 2015-05-14 09:16:10 +0100, Andrew Gierth wrote:
>  Andres> A rough sketch of what I'm thinking of is:
> 
> I'm not sure I'd do it quite like that.

It was meant as a sketch, so there's lots of things it's probably
missing ;)

> Rather, have a wrapper function get_outer_tuple that calls
> ExecProcNode and, if appropriate, writes the tuple to a tuplesort
> before returning it; use that in place of ExecProcNode in
> agg_retrieve_direct and when building the hash table.

Hm. I'd considered that, but thought it might end up being more complex
for hashing support. I'm not exactly sure why I thought that tho.



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: proposal: contrib module - generic command scheduler
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension