Re: point_ops for GiST - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: point_ops for GiST
Date
Msg-id 20150512181333.GA2519@alvh.no-ip.org
Whole thread Raw
In response to Re: point_ops for GiST  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera wrote:
> Robert Haas wrote:
> > 2009/12/30 Teodor Sigaev <teodor@sigaev.ru>:
> > > Sync with current CVS
> > 
> > I have reviewed this patch and it looks good to me.  The only
> > substantive question I have is why gist_point_consistent() uses a
> > different coding pattern for the box case than it does for the polygon
> > and circle cases?  It's not obvious to me on the face of it why these
> > aren't consistent.
> 
> Emre Hasegeli just pointed out to me that this patch introduced
> box_contain_pt() and in doing so used straight C comparison (<= etc)
> instead of FPlt() and friends.

(This is commit 4cbe473938779ec414d90c2063c4398e68a70838)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: point_ops for GiST
Next
From: Tom Lane
Date:
Subject: Re: EvalPlanQual behaves oddly for FDW queries involving system columns