Re: pgsql: Improve speed of make check-world - Mailing list pgsql-committers

On Sat, May  9, 2015 at 02:02:15PM -0400, Bruce Momjian wrote:
> Yes, I found this odd too.  It is caused by this commit:
>
>     commit dcae5faccab64776376d354decda0017c648bb53
>     Author: Peter Eisentraut <peter_e@gmx.net>
>     Date:   Thu Apr 23 08:59:52 2015 -0400
>
>         Improve speed of make check-world
>
> It basically added a'check' target dependency of 'temp-install' to
> Makefile.global.in, which added it to every Makefile containing a
> 'check' target.
>
> While you can't easily add rule action to an existing target, you can
> easily add dependencies by just mentioning the target multiple times,
> e.g.
>
>     check: dep1
>
>     check: dep2
>
>     dep1:
>         echo 1
>
>     dep2:
>         echo 2
>
>
> Running 'make check' will output '1 2'.
>
> Now, of course many check's need temp-install, but the SGML build does
> not.  The attached diff uses a symbol defined in doc/src/sgml/Makefile
> (GENERATED_SGML) to supress the temp-install target rule action.

Patch applied, with added Makefile comment.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +