Re: pg_upgrade: quote directory names in delete_old_cluster script - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_upgrade: quote directory names in delete_old_cluster script
Date
Msg-id 20150430025245.GA24354@momjian.us
Whole thread Raw
Responses Re: pg_upgrade: quote directory names in delete_old_cluster script
Re: pg_upgrade: quote directory names in delete_old_cluster script
List pgsql-hackers
On Mon, Feb 16, 2015 at 05:03:45PM -0500, Bruce Momjian wrote:
> > All of our makefiles use single quotes, so effectively the only
> > character we don't support in directory paths is the single quote itself.
>
> This seems to say that Windows batch files don't have any special
> meaning for single quotes:
>
>     http://stackoverflow.com/questions/24173825/what-does-single-quote-do-in-windows-batch-files
>
http://stackoverflow.com/questions/10737283/single-quotes-and-double-quotes-how-to-have-the-same-behaviour-in-unix-and-wind
>
> Again, is it worth doing something platform-specific?  I can certainly
> define a platform-specific macro for " or ' as and use that.  Good idea?

I have developed the attached patch to use platform-specific quoting of
path names.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: alternative compression algorithms?
Next
From: Noah Misch
Date:
Subject: Re: Make more portable TAP tests of initdb