Re: vac truncation scan problems - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: vac truncation scan problems
Date
Msg-id 20150402163943.GA2969@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: vac truncation scan problems  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: vac truncation scan problems
List pgsql-hackers
Kyotaro HORIGUCHI wrote:
> Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .
> 
> It allows vucuum freeze to be skipped and inversely lets regular
> vacuum wait for lock. The attched patch fixes it.
> 
> 
> In table_recheck_autovac, vacuum options are determined as following,
> 
>  >     tab->at_vacoptions = VACOPT_SKIPTOAST |
>  >         (dovacuum ? VACOPT_VACUUM : 0) |
>  >         (doanalyze ? VACOPT_ANALYZE : 0) |
> !>         (wraparound ? VACOPT_NOWAIT : 0);
> 
> The line prefixed by '!' looks inverted.

You're absolutely right.  My mistake.  Pushed your patch, thanks.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Abbreviated keys for Numeric
Next
From: Alvaro Herrera
Date:
Subject: Re: POLA violation with \c service=