On 2015-03-25 19:18:51 +0200, Heikki Linnakangas wrote:
> I was just about to commit the attached, which is the same as the previous
> patch with just cosmetic comment changes, but then I realized that this
> probably doesn't compile with Visual Studio 2005 or older. The code does
> "#ifdef _MSC_VER", and then uses the _mm_crc32_u64 intrinsic, but that
> intrinsic was added in Visual Studio 2008. I think we'll need a version
> check there.
Good catch.
> Or better yet, a direct configure test to check if the
> intrinsic exists - that way we get to also use it on Intel compilers, which
> I believe also has the same intrinsics.
Maybe I'm missing something, but configure isn't run for msvc?
Greetings,
Andres Freund
-- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services
