Re: flags argument for dsm_create - Mailing list pgsql-hackers

From Andres Freund
Subject Re: flags argument for dsm_create
Date
Msg-id 20150319152545.GD26995@alap3.anarazel.de
Whole thread Raw
In response to flags argument for dsm_create  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: flags argument for dsm_create  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: flags argument for dsm_create  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi,

On 2015-03-19 11:21:45 -0400, Robert Haas wrote:
> One question I struggled with is whether to keep the existing
> dsm_create() signature intact and add a new function
> dsm_create_extended().  I eventually decided against it.  The
> dsm_create() API is relatively new at this point, so there probably
> aren't too many people who will be inconvenienced by an API break now.
>   If we go ahead and create dsm_create_extended() now, and then need
> to make another API change down the line, I doubt there will be much
> support for dsm_create_extended2() or whatever.  So my gut is that
> it's better to just change this outright, and keep
> dsm_create_extended() as an idea for the future.  But I could go the
> other way on that if people feel strongly about it.

+1 for a clear API break.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: assessing parallel-safety
Next
From: Alvaro Herrera
Date:
Subject: Re: flags argument for dsm_create