Re: Strange assertion using VACOPT_FREEZE in vacuum.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Strange assertion using VACOPT_FREEZE in vacuum.c
Date
Msg-id 20150311190950.GP3291@alvh.no-ip.org
Whole thread Raw
In response to Re: Strange assertion using VACOPT_FREEZE in vacuum.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Strange assertion using VACOPT_FREEZE in vacuum.c  (Robert Haas <robertmhaas@gmail.com>)
Re: Strange assertion using VACOPT_FREEZE in vacuum.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Robert Haas wrote:
> On Fri, Mar 6, 2015 at 1:39 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:

> > - 0001 is the previous one
> > - 0002 removes VacuumStmt from the call stack of ANALYZE and VACUUM routines
> > - 0003 moves for_wraparound in VacuumParams.
> 
> Yeah, I think something like this could be a sensible approach.

But autovacuum is still manufacturing a VacuumStmt by hand.  If we want
to get rid of that, I think it'd work to have a new
ExecVacuum(VacuumStmt, params) function which is called from
standard_ProcessUtility and does just vacuum(rel, relid, params).  
Autovacuum on the other hand can call vacuum() without having to
construct the parse node.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Strange assertion using VACOPT_FREEZE in vacuum.c
Next
From: Robert Haas
Date:
Subject: Re: Strange assertion using VACOPT_FREEZE in vacuum.c