Re: Merge compact/non compact commits, make aborts dynamically sized - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Merge compact/non compact commits, make aborts dynamically sized
Date
Msg-id 20150302171406.GB22160@awork2.anarazel.de
Whole thread Raw
In response to Re: Merge compact/non compact commits, make aborts dynamically sized  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Merge compact/non compact commits, make aborts dynamically sized
List pgsql-hackers
On 2015-03-02 19:11:15 +0200, Heikki Linnakangas wrote:
> Come to think of it, it would be cleaner anyway to move the
> XLogBeginInsert() and XLogInsert() calls inside XactEmitCommitRecord. Then
> those structs don't need to be static either.

That was my first thought as well - but it doesn't easily work because
of the way commit/abort records are embedded into twophase.c.  I
couldn't come with a simple way to change that, and anythign non simple
imo defeats the purpose.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Merge compact/non compact commits, make aborts dynamically sized
Next
From: Andres Freund
Date:
Subject: Re: deparsing utility commands