Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places. - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places.
Date
Msg-id 20150221011616.GS2500@alvh.no-ip.org
Whole thread Raw
In response to Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places.
List pgsql-committers
Tom Lane wrote:

> A relevant technique that's been used in a lot of our code is to define
> an intermediate macro, along the lines of
>
> #define SizeofHeapTupleHeader offsetof(HeapTupleHeaderData, t_bits)
>
> or maybe it would better be called HeapTupleHeaderFixedSize or
> HeapTupleHeaderOverhead.  Not sure what reads most nicely.

Maybe the macro could take an argument which is the size of the data
part, so that it could be allocated together with the Overhead part; the
addition would be done in the macro rather than its caller.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places.
Next
From: Tom Lane
Date:
Subject: pgsql: Some more FLEXIBLE_ARRAY_MEMBER fixes.