Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script
Date
Msg-id 20150216214435.GC24298@momjian.us
Whole thread Raw
In response to Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script
List pgsql-committers
Tree view 
On Sun, Feb 15, 2015 at 12:02:44PM -0500, Peter Eisentraut wrote:
> On 2/11/15 10:06 PM, Bruce Momjian wrote:
> > pg_upgrade:  quote directory names in delete_old_cluster script
> >
> > This allows the delete script to properly function when special
> > characters appear in directory paths, e.g. spaces.
>
> Wouldn't single quotes be better than double quotes if you want to
> defend against special characters?

I thought of that.  Windows only does double-quotes, I think, and I
didn't see any value to doing a platform-specific quoting.  Do you?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

pgsql-committers by date:

Previous
From: Kevin Grittner
Date:
Subject: pgsql: Eliminate unnecessary NULL checks in picksplit method of intarra
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script