Re: [PATCH] HINT: pg_hba.conf changed since last config reload - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] HINT: pg_hba.conf changed since last config reload
Date
Msg-id 20150116170124.GI16991@alap3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] HINT: pg_hba.conf changed since last config reload  (Alex Shulgin <ash@commandprompt.com>)
Responses Re: [PATCH] HINT: pg_hba.conf changed since last config reload
Re: [PATCH] HINT: pg_hba.conf changed since last config reload
List pgsql-hackers
On 2014-12-15 19:38:16 +0300, Alex Shulgin wrote:
> Attached is the modified version of the original patch by Craig,
> addressing the handling of the new hint_log error data field and
> removing the client-side HINT.

I'm not a big fan of this implementation. We're adding a fair bit of
infrastructure (i.e. server-only hints) where in other places we use
NOTICE for similar hints.

Why don't we just add emit a NOTICE or WARNING in the relevant place
saying that pg_hba.conf is outdated? Then the server won't log those if
configured appropriately, which doesn't seem like a bad thing. Note that
<= ERROR messages aren't sent to the client during authentication.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: proposal: lock_time for pg_stat_database
Next
From: Jim Nasby
Date:
Subject: Re: proposal: row_to_array function