Re: Error check always bypassed in tablefunc.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Error check always bypassed in tablefunc.c
Date
Msg-id 20150116153301.GU1663@alvh.no-ip.org
Whole thread Raw
In response to Error check always bypassed in tablefunc.c  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Error check always bypassed in tablefunc.c
List pgsql-hackers
Michael Paquier wrote:

> As mentioned in $subject, commit 08c33c4 of 2003 has made the
> following block of code dead in tablefunc.c:1320 because level is
> incremented to at least 1:
>                 /* First time through, do a little more setup */
>                 if (level == 0)
>                 {

Uh.  This means the error case has no test coverage ...

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: orangutan seizes up during isolation-check
Next
From: Dave Cramer
Date:
Subject: Re: orangutan seizes up during isolation-check