Re: libpq 9.4 requires /etc/passwd? - Mailing list pgsql-hackers

From Noah Misch
Subject Re: libpq 9.4 requires /etc/passwd?
Date
Msg-id 20150110185929.GA2702533@tornado.leadboat.com
Whole thread Raw
In response to Re: libpq 9.4 requires /etc/passwd?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jan 09, 2015 at 06:57:02PM -0500, Tom Lane wrote:
> Commit a4c8f14364c27508233f8a31ac4b10a4c90235a9 turned
> failure of pg_fe_getauthname() into a hard connection failure, whereas
> previously it was harmless as long as the caller provided a username.
> 
> I wonder if we shouldn't just revert that commit in toto.  Yeah,
> identifying an out-of-memory error might be useful, but this cure
> seems a lot worse than the disease.  What's more, this coding reports
> *any* pg_fe_getauthname failure as "out of memory", which is much worse
> than useless.

+1 for reverting it as the next step

> Alternatively, maybe don't try to resolve username this way until
> we've found that the caller isn't providing any username.

and for subsequently pursuing this.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: libpq 9.4 requires /etc/passwd?
Next
From: Tom Lane
Date:
Subject: Re: libpq 9.4 requires /etc/passwd?