Re: Fixing memory leak in pg_upgrade - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Fixing memory leak in pg_upgrade
Date
Msg-id 20150110.111944.563424590546355319.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: Fixing memory leak in pg_upgrade  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
> On Fri, Jan 9, 2015 at 9:23 PM, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> This is because gen_db_file_maps() allocates memory even if n_maps == 0.
> Purely cosmetic: the initialization n_maps = 0 before the call of
> gen_db_file_maps is unnecessary ;)

Of course. n_maps is written by calling gen_db_file_maps() anyway. I
was talking about the case after calling gen_db_file_maps().

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Escaping from blocked send() reprised.
Next
From: Andres Freund
Date:
Subject: Re: Escaping from blocked send() reprised.