Fixing memory leak in pg_upgrade - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Fixing memory leak in pg_upgrade
Date
Msg-id 20150109.212350.1299395873280569132.t-ishii@sraoss.co.jp
Whole thread Raw
Responses Re: Fixing memory leak in pg_upgrade
Re: Fixing memory leak in pg_upgrade
List pgsql-hackers
According to Coverity, there's a memory leak bug in transfer_all_new_dbs().
    mappings = gen_db_file_maps(old_db, new_db, &n_maps, old_pgdata,                                new_pgdata);
    if (n_maps)    {        print_maps(mappings, n_maps, new_db->db_name);

#ifdef PAGE_CONVERSION        pageConverter = setupPageConverter();
#endif        transfer_single_new_db(pageConverter, mappings, n_maps,                               old_tablespace);
        pg_free(mappings);    }
-----> leaks "mappings"}return;
}

This is because gen_db_file_maps() allocates memory even if n_maps == 0.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: INSERT ... ON CONFLICT UPDATE and RLS
Next
From: Michael Paquier
Date:
Subject: Re: Fixing memory leak in pg_upgrade