Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c
Date
Msg-id 20144.1005497827@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> How about this:

> elog(xxx, "whatever process (pid %d) terminated abnormally (%s)", formatExitStatus(exit_status));

> where formatExitStatus() returns either of

> "exit status 77"
> "signal 11"

But exit status 0 is not abnormal.  I guess in the CleanupProc case
you could leave out the word "abnormally" and just say terminated (%s).

> I see you already made some changes.  Sorry that it took me a while to
> respond, but I can make these changes if we can agree.

I took your lack of comment as assent ... if you want to change it as
above, I won't object, but I think what's there now is workable as long
as the translator understands that the two sets of messages go together.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] Bug #513: union all changes char(3) column definition
Next
From: Stephan Szabo
Date:
Subject: Triggered Data Change check