Re: Missing updates at few places for row level security - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Missing updates at few places for row level security
Date
Msg-id 20141223121132.GA3062@tamriel.snowman.net
Whole thread Raw
In response to Missing updates at few places for row level security  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Amit,

* Amit Kapila (amit.kapila16@gmail.com) wrote:
> There is a new column added in pg_authid (rolbypassrls)
> and the updation for same is missed in below places:
>
> a. System catalog page for pg_authid
> http://www.postgresql.org/docs/devel/static/catalog-pg-authid.html

Yup, thanks, will fix.

> b. Do we want to add this new column in pg_shadow view?

This was intentionally not done as I had really viewed pg_user, pg_group
and pg_shadow as deprecated and only for backwards-compatibility.
That's certainly why those views were added originally.  On the other
hand, I do see that 'userepl' was added, so we've been keeping it
updated.

I am inclined to suggest that we actually mark pg_user, pg_group, and
pg_shadow as deprecated and planned for removal.  We can't simply remove
them as we haven't actually said that but I don't think we should
continue to carry these pre-8.1 views around forever.  Still, until we
do that, we should keep them updated.

I'll make these changes in the next couple of days (after the role
attribute bitmask patch, as that touches a lot of the same places).
Thanks,
    Stephen

pgsql-hackers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: speedup tidbitmap patch: cache page
Next
From: Tomas Vondra
Date:
Subject: Re: Initdb-cs_CZ.WIN-1250 buildfarm failures