Re: pgsql: doc: restrictions on alter database moving default tablespace - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: doc: restrictions on alter database moving default tablespace
Date
Msg-id 20141212211450.GA7456@momjian.us
Whole thread Raw
In response to Re: pgsql: doc: restrictions on alter database moving default tablespace  (Noah Misch <noah@leadboat.com>)
Responses Re: pgsql: doc: restrictions on alter database moving default tablespace  (Noah Misch <noah@leadboat.com>)
List pgsql-committers
On Tue, Oct 21, 2014 at 01:38:43AM -0400, Noah Misch wrote:
> On Sat, Oct 18, 2014 at 02:23:46PM +0000, Bruce Momjian wrote:
> > doc:  restrictions on alter database moving default tablespace
> >
> > Mention tablespace must be empty and no one connected to the database.
>
> The database must not contain any object explicitly assigned to its future
> default tablespace, but that tablespace need not be empty.  Objects of other
> databases in the tablespace pose no problem.

I am back to look at this comment, and I don't understand what change is
being requested.  Are you saying it is just the commit message that
isn't clear?

The new text is:

    The new default tablespace for this database must be empty, and no one
    can be connected to the database.

That makes the distinction that only the tablespace for the existing
database has to be empty, not the entire tablespace.  Also, how would
there be an entry in the new-default per-database tablespace without it
being explicitly assigned, as that was not the previous default.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid instability in output of new REINDEX SCHEMA test.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Remove duplicate #define