Re: no test programs in contrib - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: no test programs in contrib
Date
Msg-id 20141127222649.GV1639@alvin.alvh.no-ip.org
Whole thread Raw
In response to Re: no test programs in contrib  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

> I'm not too happy with that approach, because packagers are going to
> tend to think they should package any files installed by install-world.
> The entire point of this change, IMO, is that the test modules should
> *not* get installed, certainly not by normal install targets.  Being
> consistent with the existing contrib packaging is exactly not what we
> want.
>
> Maybe we should only allow check-world to run these tests, and not
> installcheck-world?  That's kind of annoying, but what you are
> doing now seems to defeat the purpose altogether.

Hadn't thought of the packaging angle of this.  I don't think packagers
really are as dumb as you suggest, but anyway implementing this idea
turned out to be simpler than I expected; here's a preliminary patch.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: no test programs in contrib
Next
From: Peter Geoghegan
Date:
Subject: Re: [pgsql-packagers] Palle Girgensohn's ICU patch