Re: postgresql.auto.conf comments - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: postgresql.auto.conf comments
Date
Msg-id 20141124204011.GZ28859@tamriel.snowman.net
Whole thread Raw
In response to postgresql.auto.conf comments  (Thom Brown <thom@linux.com>)
Responses Re: postgresql.auto.conf comments  (Thom Brown <thom@linux.com>)
List pgsql-hackers
* Thom Brown (thom@linux.com) wrote:
> I haven't seen this mentioned anywhere (although it may have as I haven't
> read through the entire history of it), but would others find it useful to
> have ALTER SYSTEM support comments?

I do think it'd be useful.  I don't think 'inline' deserves inclusion
and just complicates it more than necessary (my 2c at least).  I'd just
do them all as 'headline' and wrap at 80 chars.

I will point out that this use of COMMENT is novel though, no?  Comments
are normally handled as "COMMENT ON blah IS 'whatever';"  ALTER SYSTEM
is certainly special but I'm not sure I like the idea of having some
commands which support in-command COMMENT while others don't.

> The rationale being that it's often the case one wants to document the
> reason for a parameter being configured so, but there's no way of doing
> this for settings in postgresql.auto.conf as they'll be wiped out if added
> manually.

<<Comments about postgresql.auto.conf redacted>>
Thanks,
    Stephen

pgsql-hackers by date:

Previous
From: Adam Brightwell
Date:
Subject: Role Attribute Bitmask Catalog Representation
Next
From: Thom Brown
Date:
Subject: Re: postgresql.auto.conf comments