Re: narwhal and PGDLLIMPORT - Mailing list pgsql-hackers

From Noah Misch
Subject Re: narwhal and PGDLLIMPORT
Date
Msg-id 20141020152426.GA259630@tornado.leadboat.com
Whole thread Raw
In response to Re: narwhal and PGDLLIMPORT  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Oct 20, 2014 at 11:06:54AM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > I don't expect to understand the mechanism
> > behind it, but I recommend we switch back to linking libpq with shell32.dll.
> > The MSVC build already does that in all supported branches, and it feels right
> > for the MinGW build to follow suit in 9.4+.  Windows versions that lack the
> > symbol in shell32.dll are now ancient history.
> 
> This is basically reverting 889f038, right?

Mostly so.  Keeping the SHGetSpecialFolderPath() -> SHGetFolderPath() part,
but reverting the shell32.dll -> shfolder.dll part.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: narwhal and PGDLLIMPORT
Next
From: Greg Stark
Date:
Subject: Re: Proposal: Log inability to lock pages during vacuum