Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX
Date
Msg-id 20141008060027.GA348882@tornado.leadboat.com
Whole thread Raw
In response to Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Oct 06, 2014 at 08:57:54PM -0400, Tom Lane wrote:
> I eventually realized that the critical difference was you'd added
> "CFLAGS=" to the configure call.  On this platform that has the net
> effect of removing -O2 from the compiler flags, and apparently that
> shifts around the stack layout enough to expose the clobber.
> 
> The fix is simple enough: ecpg's version of ParseDateTime is failing
> to check for overrun of the field[] array until *after* it's already
> clobbered the stack:

Thanks for tracking that down.  Oops.



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: pgaudit - an auditing extension for PostgreSQL
Next
From: Heikki Linnakangas
Date:
Subject: Re: pg_receivexlog --status-interval add fsync feedback