Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE - Mailing list pgsql-hackers

From Andres Freund
Subject Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE
Date
Msg-id 20140930210328.GT2084@awork2.anarazel.de
Whole thread Raw
In response to Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
On 2014-09-30 13:42:11 -0700, Peter Geoghegan wrote:
> On Tue, Sep 30, 2014 at 12:57 PM, Christoph Berg <myon@debian.org> wrote:
> > It's probably not really a PostgreSQL bug, but it seems easy enough to
> > rename that definition now as it's only present in 9.4+. It's only
> > used in one file, xlog.c: 375d8526f2900d0c377f44532f6d09ee06531f67
> 
> 
> I agree. It should be renamed to PG_CACHE_LINE_SIZE.

Agreed. Unless somebody protests I'll do so tomorrow.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: libpq-dev: pg_config_manual.h redefines CACHE_LINE_SIZE
Next
From: Andres Freund
Date:
Subject: Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}