Re: pg_xlogdump --stats - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: pg_xlogdump --stats
Date
Msg-id 20140919100937.GA24243@toroid.org
Whole thread Raw
In response to Re: pg_xlogdump --stats  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: pg_xlogdump --stats
Re: pg_xlogdump --stats
List pgsql-hackers
I've attached the revised patch, split up differently:

1. Introduce rm_identify, change rm_desc, glue the two together in
   xlog.c
2. Introduce pg_xlogdump --stats[=record].

The requested changes (16, filter, z:, UNKNOWN) are included. The
grammar nitpicking and rebase cruft is^Ware^Wain't included.

I ran Postgres with WAL_DEBUG for a while, and I ran pg_xlogdump with
--stats (and --stats=rmgr) and --stats=record with and without a few
different variants of "-r heap". Everything looked OK to me.

I hope I didn't miss anything this time.

-- Abhijit

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: GCC memory barriers are missing "cc" clobbers
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: pg_xlogdump --stats