Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64 - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64
Date
Msg-id 20140917155919.GD25775@awork2.anarazel.de
Whole thread Raw
In response to pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
List pgsql-committers
Hi,

On 2014-08-21 06:57:20 +0000, Heikki Linnakangas wrote:
> Add #define INT64_MODIFIER for the printf length modifier for 64-bit ints.
>
> We have had INT64_FORMAT and UINT64_FORMAT for a long time, but that's not
> good enough if you want something more exotic, like "%20lld".
>
> Abhijit Menon-Sen, per Andres Freund's suggestion.

Unfortunately this patch broke at least
PGAC_FUNC_SNPRINTF_SIZE_T_SUPPORT because that uses UINT64_FORMAT.

I only noticed because I noticed pg_vsnprintf()s in the profile. Which I
didn't use to see ;)

Abhijit: I'll later push a fix for PGAC_FUNC_SNPRINTF_SIZE_T_SUPPORT,
but it'd good if you could check whether a configure before/after this
commit changes other uintended things.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix TAP checks when current directory name contains spaces
Next
From: Andres Freund
Date:
Subject: pgsql: Fix configure check for %z printf support after INT64_MODIFIER c