Re: KNN-GiST with recheck - Mailing list pgsql-hackers

From Emre Hasegeli
Subject Re: KNN-GiST with recheck
Date
Msg-id 20140917081250.GA28651@hasegeli.com
Whole thread Raw
In response to Re: KNN-GiST with recheck  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: KNN-GiST with recheck  (Emre Hasegeli <emre@hasegeli.com>)
List pgsql-hackers
> > While looking it at I found a bug.  It returns the second column
> > in wrong order when both of the distance functions return recheck = true.
> > Test script attached to run on the regression database.  I tried to
> > fix but could not.  searchTreeItemDistanceRecheck function is not
> > very easy to follow.  I think it deserves more comments.
>
> Fixed, thanks. It was logical error in comparison function implementation.

I managed to break it again by ordering rows only by the second column
of the index.  Test script attached.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: jsonb format is pessimal for toast compression
Next
From: Emre Hasegeli
Date:
Subject: Re: KNN-GiST with recheck