On 2014-09-11 09:52:20 +0900, Michael Paquier wrote:
> > I'd not mind a review, but I'll push this soon. Doesn't seem worth
> > reverting the entire psql patch when the fix is as localized as this. We
> > might conceivably want to change the behaviour of optional_argument, but
> > as there's only one caller at this point.
> Thanks. Even if we are not on the same timezone, you could have waited
> a bit for some feedback from someone with Windows environment IMO. It
> is always good to have an insurance.
The reason that I pushed it quickly was that windows on the buildfarm
already was broken. This wouldn't (and afaics hasn't) make it any worse.
The longer members stay read, the more changes can be in that broken
window. Thus it gets harder to pinpoint problems. It's also not like any
code in getopt_long.c is particularly windows specific - after including
in Makefile.global it can easily be run on linux.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
