Michael Paquier wrote:
> On Wed, Sep 10, 2014 at 10:04 AM, Andres Freund <andres@anarazel.de> wrote:
> > The best plan after that seems to be to add optional_argument support to
> > getopt_long.c - looks easy enough. Do we need a configure test for
> > optional_argument? I don't think so, but I could see somebody arguing
> > the other way round.
> Adding support for optional_argument in src/port would be the best
> solution for long-term purposes. So +1 for it or we'll be limited in
> the future as well. Here is for example attached a proof-of-concept
> patch that it is not that complicated to add support for optional
> arguments... Interestingly, the current implementation dates of 2003
> in 939a59f and has not been majorly touched since. The patch has been
> tested with MSVC.
Hmm, IIRC (didn't check) we only use our getopt_long if the platform
doesn't have one. But what if the platform has one and it doesn't
support optional_argument? I think we'd need additional configure black
magic to ensure that our version is chosen in these cases.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
