I started editing these patches for commit, but I ran into two defects.
First, clean.bat requires an update to remove the new win32ver.rc files.
Second, the MinGW build uses few or none of the new PGFILEDESC entries; you
need to mention $(WIN32RES) as in (most) existing PGFILEDESC-using makefiles.
Here are the patches as they stood at the time of those discoveries.
Project::AddDir() does more than look for PGFILEDESC. Your patches placed
AddDir calls next to code made redundant by those calls; I removed the
now-redundant code. I prefer four-argument Solution::AddProject() over
three-argument Solution::AddProject() followed promptly by Project::AddDir(),
but that was a mere cosmetic judgement. Our prevailing style is to not
uppercase the letter after the hyphen in PGFILEDESC, and I edited PGFILEDESC
wording here and there. Please update these to fix the two bugs noted above.
You requested a back-patch, but no part of this change qualifies. Even given
a back-patch, automata checking this metadata should point at one of the files
that already has it.
On Sat, Jun 21, 2014 at 10:13:40PM +0900, Michael Paquier wrote:
> On Sat, Jun 21, 2014 at 11:47 AM, MauMau <maumau307@gmail.com> wrote:
> > bin\isolationtester.exe
> > bin\pg_isolation_regress
> > bin\pg_regress.exe
> > bin\pg_regress_ecpg.exe
> > bin\zic.exe
> > lib\dict_snowball.dll
> > lib\regress.dll
> Yes, I'd like to improve that in a next patch hopefully in CF2, except
> if a committer picking up this patch thinks differently.
While I'd have preferred to see all binaries covered at once, that's fine.
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
