Re: [PATCH] introduce XLogLockBlockRangeForCleanup() - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Date
Msg-id 20140703061139.GF10574@toroid.org
Whole thread Raw
In response to Re: [PATCH] introduce XLogLockBlockRangeForCleanup()  (Amit Khandekar <amit.khandekar@enterprisedb.com>)
Responses Re: [PATCH] introduce XLogLockBlockRangeForCleanup()  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
List pgsql-hackers
At 2014-07-03 11:15:53 +0530, amit.khandekar@enterprisedb.com wrote:
>
> In GetBufferWithoutRelcache(), I was wondering, rather than calling
> PinBuffer(), if we do this :
> LockBufHdr(buf);
> PinBuffer_Locked(buf);
> valid = ((buf->flags & BM_VALID) != 0);
> then we can avoid having the new buffer access strategy BAS_DISCARD
> that is introduced in this patch. And so the code changes in
> freelist.c would not be necessary.

Thanks for the suggestion. It sounds sensible at first glance. I'll
think about it a little more, then try it and see.

> > will follow up with some performance numbers soon.
> 
> Yes, that would be nice.

I'm afraid I haven't had a chance to do this yet.

-- Abhijit



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WAL replay bugs
Next
From: Amit Kapila
Date:
Subject: Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]