Hi.
I reviewed the version of this patch without log_line_prefix support,
since that seemed to be generally acceptable in followup discussion.
The patch didn't apply any more because of some changes to guc.c, but it
was trivial to regenerate (fixed patch attached).
> diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
> index 70e5a51..84ae5f3 100644
> --- a/src/backend/utils/misc/postgresql.conf.sample
> +++ b/src/backend/utils/misc/postgresql.conf.sample
> @@ -74,6 +74,8 @@
> # (change requires restart)
> #bonjour_name = '' # defaults to the computer name
> # (change requires restart)
> +#cluster_name = '' # defaults to the computer name
> + # (change requires restart)
Cut-and-paste error (there's no default). Also fixed in the attached
patch.
The patch looks OK, and works as advertised (I tested on Linux). If we
want the feature (I like it), this patch is a good enough way to get it.
I'm marking it ready for committer.
-- Abhijit
