Re: rm_desc signature - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: rm_desc signature
Date
Msg-id 20140613123327.GR5162@toroid.org
Whole thread Raw
In response to Re: rm_desc signature  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
At 2014-06-13 13:39:58 +0200, andres@2ndquadrant.com wrote:
>
> > void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec);
> > void (*rm_desc) (StringInfo buf, XLogRecord *record);
> > 
> > […]
> 
> +1. I've found this annoying in the past.

I like it too. I was just moving some code from pg_xlogdump into another
(new) rm_desc-like callback, and passing in the XLogRecord makes much
more sense to me.

-- Abhijit



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: rm_desc signature
Next
From: Tom Lane
Date:
Subject: Re: PL/pgSQL support to define multi variables once