Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs
Date
Msg-id 20140531140255.GB4286@awork2.anarazel.de
Whole thread Raw
In response to Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs
List pgsql-hackers
On 2014-05-30 08:12:35 +0900, Michael Paquier wrote:
> On Fri, May 30, 2014 at 5:31 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > Thanks, this looks good.  But shouldn't the bit about output plugin
> > options mention say something like:
> >
> > ( option_name option_argument [, ...] )
> >
> > ...instead of just:
> >
> > ( option [, ...] )
> > ?
> Yes, true. Here is an updated patch.

I've pushed the patch with some additional changes. Hope they make sense
to you.

I wonder whether START_REPLICATION ... LOGICAL should be folded into
... PHYSICAL since they have most things in common. But it'd be a
awfully complicated description.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: recovery testing for beta
Next
From: Andres Freund
Date:
Subject: Re: FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch