Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files. - Mailing list pgsql-committers

From Andres Freund
Subject Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Date
Msg-id 20140529132535.GL27914@awork2.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
List pgsql-committers
On 2014-05-29 08:33:05 -0400, Peter Eisentraut wrote:
> On 5/28/14, 7:02 PM, Andres Freund wrote:
> > That's a good idea. What i've been thinking about is to add
> > -Wno-deprecated to the bison rule in the interim. Maybe after a
> > configure test for the option. All deprecation warnings so far seem to
> > be pretty unhelpful.
>
> Here is a patch.

FWIW, I vote for applying something like it. It seems better to collect
the -Wno-deprecated in one place (i.e. configure) instead of having it
in every developer's Makefile.custom. The latter will be harder to get
rid of.
I'd add a comment about why it's been added though. I won't remember why
at least...

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.