Re: Allowing line-continuation in pgbench custom scripts - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Allowing line-continuation in pgbench custom scripts
Date
Msg-id 20140526175302.GB11572@awork2.anarazel.de
Whole thread Raw
In response to Re: Allowing line-continuation in pgbench custom scripts  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Allowing line-continuation in pgbench custom scripts  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2014-05-26 11:44:31 -0400, Tom Lane wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
> > In a custom pgbench script, it seems convenient to be able to split a
> > really long query to span multiple lines using an escape character
> > (bash-style). Attached adds that capability to read_line_from_file()
> > in pgbench.c
> 
> This seems pretty likely to break existing scripts that happen to contain
> backslashes.  Is it really worth the compatibility risk?

Weaknesses in the implementation aside, I don't think pgbench has to be
hold up to the same level of compatibility as many of our other
tools. It's just a benchmark tool after all.

I've more than once wished for the capability.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Matteo Beccati
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD